% Calcium in a seashell?

Your approach is correct. Calculate the moles of CaC2O4 x H2O, which equals moles Ca since there is one mole of Ca per mole of CaC2O4 x H2O. Then convert moles Ca to g Ca, and then % Ca.